]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Do not bind popdown call to grabHelper onUngrab
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 4 Feb 2021 16:37:02 +0000 (17:37 +0100)
committerMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 4 Feb 2021 20:55:34 +0000 (21:55 +0100)
grabHelper is passing a boolean argument to onUngrab() callback function
and since commit 1acbdcc9b3b0 we'd end up adding it to to the callback list or
we'd try to invoke it:

 (gnome-shell:3490851): Gjs-CRITICAL **: 17:19:20.460: JS ERROR:
  TypeError: func is not a function
  onComplete/<@/media/M2/GNOME/gnome-shell/js/ui/appDisplay.js:2407:56
  onComplete@/media/M2/GNOME/gnome-shell/js/ui/appDisplay.js:2407:40
  _makeEaseCallback/<@/media/M2/GNOME/gnome-shell/js/ui/environment.js:85:13
  _easeActor/<@/media/M2/GNOME/gnome-shell/js/ui/environment.js:170:64

Use an arrow function so that we can control the parameters we pass
to popdown.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1635>

js/ui/appDisplay.js

index 2d81a85164bd3e0ab657ebc2d8e9977f1301c9fb..69b4d0fff5a2491ef937c07cb09917d5244be91c 100644 (file)
@@ -2574,8 +2574,10 @@ var AppFolderDialog = GObject.registerClass({
         if (this._isOpen)
             return;
 
-        this._isOpen = this._grabHelper.grab({ actor: this,
-                                               onUngrab: this.popdown.bind(this) });
+        this._isOpen = this._grabHelper.grab({
+            actor: this,
+            onUngrab: () => this.popdown(),
+        });
 
         if (!this._isOpen)
             return;